search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 8 forks source link

CompatHelper: bump compat for Oceananigans to 0.71, (keep existing compat) #67

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the Oceananigans package from ^0.70 to ^0.70, 0.71. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

tomchor commented 2 years ago

@glwagner for this latest Oceananigans version we need to figure out how to deal with the ScalarDiffusivity in places like this: https://github.com/tomchor/Oceanostics.jl/blob/da1d9174480df4bacd05b0e050fa9f25f51ab337/src/TKEBudgetTerms.jl#L188-L214

Do you have any ideas?

Also, the tests passed here, but they really shouldn't have passed. They definitely fail when I run them locally on my laptop. Do you have any idea of what's going on?