search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 8 forks source link

Progress messenger improvements #69

Closed glwagner closed 1 year ago

glwagner commented 2 years ago

Bit of a catch-all issue:

  1. Both SimpleProgressMessenger and SingleLineProgressMessenger are TitleCase but don't actually return objects. Let's fix this because it can mislead people (me, for example)
  2. There's much shared code between the progress messengers. 3x copy/paste makes it 3x harder to improve the code. #68 helps a bit but there's still some to do.
tomchor commented 2 years ago

Agreed!

I've thought about the amount of shared code between progress messengers, but couldn't figure out a good solution yet. I like what you did in #68 though.