search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 9 forks source link

CompatHelper: bump compat for Oceananigans to 0.73, (keep existing compat) #72

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the Oceananigans package from ^0.71, 0.72 to ^0.71, 0.72, 0.73. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

navidcy commented 2 years ago

hey @tomchor you need help with this?

navidcy commented 2 years ago

I suggest bump a release with this? And if it requires breaking changes because of Oceananigans v0.73 then perhaps drop the compatibility with 0.71, 0.72?

tomchor commented 2 years ago

hey @tomchor you need help with this?

That would really help me out since I haven't had time to look into the errors unfortunately...

Thanks!

tomchor commented 2 years ago

I suggest bump a release with this? And if it requires breaking changes because of Oceananigans v0.73 then perhaps drop the compatibility with 0.71, 0.72?

Agreed!

navidcy commented 2 years ago

See #73 :) Merge it here?

(if you give me write access I could have committed to this branch)

glwagner commented 2 years ago

@navidcy can you open a PR to merge your patch into this branch?

glwagner commented 2 years ago

This PR is ready to merge when we're ready

glwagner commented 2 years ago

Nevermind, I figured it out!