search

tomchor / Oceanostics.jl

Diagnostics for Oceananigans
https://tomchor.github.io/Oceanostics.jl/
MIT License
24 stars 8 forks source link

Adds some support and tests for `HydrostaticModel`s #85

Closed tomchor closed 1 year ago

tomchor commented 1 year ago

For now only a few functions are tests for hydrostatic models, but it's a start

tomchor commented 1 year ago

All tests pass locally. Not sure the current error means or how to fix it...

whitleyv commented 1 year ago

These weren't part of your changes for the review, but do these need to be YPressure... / ZPressure...? https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L113 https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L116

tomchor commented 1 year ago

These weren't part of your changes for the review, but do these need to be YPressure... / ZPressure...?

https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L113

https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L116

Not really. These were and still are passing in previous tests so they should be good :)