search

tomcorbett / opentok-laravel

Laravel bundle for OpenTok
MIT License
9 stars 23 forks source link

What about Laravel 5 support? #5

Closed simplenotezy closed 8 years ago

tomcorbett commented 9 years ago

Hi @canfiax I am not using laravel 5 yet and am not currently actively using laravel either, as I am very busy on other projects at the moment, but if you want to put in a pull request for the necessary changes, please feel free. Apologies for this!

namelivia commented 8 years ago

Hey, I've forked this repository and modified it for Laravel 5+ (it's currently successfully implemented in one of our 5.2 projects). I don't exactly know about the retrocompatibility of this but I think it is not retrocompatible so I don't know if merging a PR would break things for some other people projects.

tomcorbett commented 8 years ago

Hi @namelivia thank you very much for that! I am fine with merging in and just tagging a new release 1.1.0 or something like that and I or you can update the readme to let people know which version to use for which versions of Laravel?

namelivia commented 8 years ago

Ok, I'll be cleaning up things a bit and make a PR. Thanks!

tomcorbett commented 8 years ago

@namelivia awesome thank you!

zedee commented 8 years ago

Seems that I did the same some days ago with this repo! But I think @namelivia version is better adapted. Not sure though, some willing to check?

namelivia commented 8 years ago

I have created a pull request, I was updating the documentation and rebasing so guys can go ther and take a look to see if something looks weird to you or could be improved. Thanks!