search

tomcorbett / opentok-laravel

Laravel bundle for OpenTok
MIT License
9 stars 23 forks source link

Laravel 5 update #7

Closed namelivia closed 8 years ago

namelivia commented 8 years ago

This PR is made to resolve #5 by making some small adaptations. The style and organization is based on some popular Laravel 5 libraries like barryvdh/laravel-cors and GrahamCampbell/Laravel-Flysystem.

Important! In order not to lose retrocompatibility I think the major version number should be bumped, and also like I've seen in laravel-cors, maybe a 1.0 branch should be made before for redirecting Laravel 4 users there (The readme is already pointing there). This would also need to make minor changes in the documentation for the old an new version, specifying the version on the composer.json example in the installation section.

Feel free to comment and critizise everything you want.

tomcorbett commented 8 years ago

Thanks @namelivia very much for this, I have tagged the new release https://github.com/tomcorbett/opentok-laravel/releases/tag/v1.1.0 so we can still support both and thank you for updating the readme!