search

tomdale / ember-cli-addon-tests

31 stars 18 forks source link

[WIP] Allowing link to be the absolute last step in the process #186

Open mansona opened 6 years ago

mansona commented 6 years ago

This is a work in progress PR that is supposed to spark a discussion around https://github.com/tomdale/ember-cli-addon-tests/issues/176. it is also related to https://github.com/kaliber5/ember-fastboot-addon-tests/issues/21

The idea is that we need to have the linking be the last step in the process after all times that npm install is called. As ember-fastboot-addon-tests does some npm magic of its own it would need to run the linking functionality again at a time that is suitable for that addon. I have a demo of what I was trying to achieve https://github.com/kaliber5/ember-fastboot-addon-tests/pull/22

simonihmig commented 6 years ago

@mansona I am not sure, are the changes in pristine.js really necessary (except for exposing the link function)? AFAICT, it is not calling npm install after symlinking the addon, or do I miss something? It's just ember-fastboot-addon-tests which should call AddonTestApp.link() after doing its own npm install.

Tests are broken at least...

mansona commented 6 years ago

@simonihmig you're right in saying that this is mostly for ember-fastboot-addon-tests to do the symlinkAddon() after its own npm install, but that really doesn't work.

To be honest I'm surprised that you haven't come back to say my approach was a million miles off 🤔 I guess if I could get this working "downstream" with these changes I might be able to clean this up and expose symlinkAddon() correctly 👍