search

tomdale / ember-cli-addon-tests

31 stars 18 forks source link

ember-data master Rollup build error #199

Closed xg-wang closed 5 years ago

xg-wang commented 5 years ago 
23:51:45 in ember-cli-fastboot on ๎‚  master [!] is ๐Ÿ“ฆ v2.0.0 via ๐Ÿน 3.3.0 took 40s
[I] โžœ yarn test
yarn run v1.10.1
$ mocha && ember test

  rewriting HTML
    1) builds an index.html that points to the browser build
cleaning up...

Build failed.

Build Error (Rollup)

Could not resolve './references/record' from tmp/rollup-cache_path-23iVf97F.tmp/build/-private/system/references.js

Also failed a new kicked travis-ci https://travis-ci.com/xg-wang/ember-cli-fastboot/jobs/160253348

xg-wang commented 5 years ago

Some commit in ember-data#master caused this, I don't see this error yesterday. cc @runspired @kellyselden

kellyselden commented 5 years ago

Can we close this since it's not an issue here?

runspired commented 5 years ago

We donโ€™t know itโ€™s not an issue here, only that apparently ember-data master and here are not compatible. Both do weird build things.

kellyselden commented 5 years ago

OK thanks for the heads up.

mistahenry commented 5 years ago

https://github.com/tomdale/ember-cli-addon-tests/blob/5d4cea6163fc6264539b98577b36df7ca1a56519/lib/utilities/pristine.js#L97-L98

This seems like a risky default. Any reason not to use latest instead?

igorT commented 5 years ago

https://github.com/emberjs/data/pull/5757 is the commit which broke it

runspired commented 5 years ago

I've confirmed that new apps using ember-data master do not break due to the above ember-data commit, only things using ember-cli-addon-tests, so it's not necessarily a fundamental issue with how ember-data is configured to build / publish: it may be an issue with how this repo is consuming it.

Edit: To clarify: what I tested was an app specifying canary via use of "ember-data": "emberjs/data#master" in it's package.json

runspired commented 5 years ago

Update: We don't fail when installing canary via yarn, but we DO fail on a new app when installing canary via npm.

runspired commented 5 years ago

@igorT found this https://github.com/yarnpkg/yarn/issues/2090 which means this IS an issue with ember-data as we need to find a way to publish that won't blow up for npm and won't blow up if yarn is fixed to respect .npmignore on installs from git artifacts.

igorT commented 5 years ago

Should be fixed now

rwjblue commented 5 years ago

Why is this repo using non-released versions of ember-data at all? If we must do this then we will need to setup tarball publishing along the lines of what ember-source does.