search

tomdale / ember-cli-addon-tests

31 stars 18 forks source link

Test against ember-data ^3.8.0 #208

Closed kiwiupover closed 5 years ago

kiwiupover commented 5 years ago

https://github.com/ember-fastboot/ember-cli-fastboot/pull/679

ember-cli-addon-test by default tests against ember-data#master this PR removes #master and uses ^3.8.0

Updates ember-cli to 3.8.0

https://github.com/ember-engines/ember-engines/pull/638

xg-wang commented 5 years ago

I had another PR sometime before, which test against ember-cli generated new app. https://github.com/tomdale/ember-cli-addon-tests/pull/200

kiwiupover commented 5 years ago

@xg-wang Is this all there is to your PR to test against ember-cli generated new app https://github.com/tomdale/ember-cli-addon-tests/pull/200

I thought I had seen a PR with a 30 file change?

xg-wang commented 5 years ago

@kiwiupover Yea it is. I removed the canary-test (ember data master) and is now using the tests/dummy. The 30 file change was adding a new test/canary-app