search

tomdale / ember-cli-addon-tests

31 stars 18 forks source link

Throws with portfinder@1.0.22 #212

Closed jelhan closed 5 years ago

jelhan commented 5 years ago

Portfinder 1.0.22 released a few hours ago reduced the default highestPort from 65535 to 40000. This addon uses port 49741 by default: https://github.com/tomdale/ember-cli-addon-tests/blob/6e4d2bd20efce50b3236980e4ac211c98962d9d4/lib/commands/start-server.js#L13

Since 49741 > 40000 and it doesn't pass a customhighestPort option, portfinder throws:

Provided options.stopPort(40000is less than options.startPort (49741)

jelhan commented 5 years ago

It's the same error as if running ember serve --port 49741 with portfinder@1.0.22.

rwjblue commented 5 years ago

FYI - portfinder@1.0.23 was released with the same code as 1.0.21 to mitigate issues while they figure out the fix forward.