search

tomdesair / tus-java-server

Library to receive tus v1.0.0 file uploads in a Java server environment
MIT License
128 stars 60 forks source link

Replaces javax.xml.bind.DatatypeConverter with apache commons Base64 #15

Closed nschwalbe closed 5 years ago

nschwalbe commented 5 years ago

To not depend on javax.xml.bind package which is not included in java 11, I replaced the DatatypeConverter for Base64 en-/decoding with the Base64 encoder from apache commons-codec. When the project removes java 1.7 support it could also the java.util.Base64 encoder from java 8 be used.

Tests do not run with jdk11 because there are some problems with the surefire and jacoco maven plugin.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 96.533% when pulling 150b6cf78c9bd57ae568dcb363d4ece19799a100 on nschwalbe:feature/jdk11 into 5b032fa5905494f124238862ade56ece34851583 on tomdesair:master.

tomdesair commented 5 years ago

Thanks for your contribution @nschwalbe! The code looks good and it's a solution to solve issue #14. I'll create a separate PR to test JDK11 support using Travis.