Remove useless dependency on commons-codec

tomdesair / tus-java-server

Library to receive tus v1.0.0 file uploads in a Java server environment

MIT License

131 stars 62 forks source link

Remove useless dependency on commons-codec #2

Closed Maxoid closed 6 years ago

Maxoid commented 6 years ago

Sorry for the little mess with the imports...

tomdesair commented 6 years ago

Hi @Maxoid,

Thank you very much for your pull request. This would indeed be an improvement!

But apparently there was still a Travis configuration issue that made the SonarCloud code style checks fail. I've pushed some changes to the master branch to correct this.

Could you rebase your branch on these changes and push again? Normally the Travis build should work then.

I'll try to finalise the documentation and push this jar to Maven in the coming week.

Maxoid commented 6 years ago

Hi @tomdesair ! Seems, it didn't help.

tomdesair commented 6 years ago

Apparently SonarCloud does not support analyzing pull-requests from forks. Therefor I made a few changes in the master branch so that Sonar is not executed on pull-requests from forks. In addition I've configured Coveralls.io to check on the unit test coverage.

Could you please pull these changes into your branch and try again? Thanks!

coveralls commented 6 years ago

Coverage increased (+0.003%) to 96.651% when pulling d2f9a82acf1e007d1637450970c2060a358c7101 on Maxoid:master into c3314371974b4500191e8570df284ae556db8937 on tomdesair:master.

Maxoid commented 6 years ago

Great work @tomdesair ! Why not put it on the list of implementation at tus.io ? It much better than the official one.

tomdesair commented 6 years ago

Once I've uploaded the Jar to Maven, I'll ask the people of tus.io to list this repository on the implementations page. And thanks again for the help!