search

tomdesair / tus-java-server

Library to receive tus v1.0.0 file uploads in a Java server environment
MIT License
131 stars 62 forks source link

Added ability to share IdFactory across custom Storage implementations #4

Closed Maxoid closed 6 years ago

Maxoid commented 6 years ago

Hi again!

IdFactory should be the same in different components.

tomdesair commented 6 years ago

Thanks for the improvement @Maxoid! I have one small suggestion for your next pull-request:

  1. Add this repo as an upstream remote: https://help.github.com/articles/configuring-a-remote-for-a-fork/

  2. Reset your master branch to this repositories master branch:

    $ git fetch upstream
$ git checkout master
$ git reset --hard upstream/master`
$ git push origin master --force

    (Note that this will erase any pending changes on your master branch!)

  3. Before starting development on a new improvement, create a new branch from master. For this improvement you could have made a branch as follows: $ git checkout -b Share_IdFactory

  4. When your ready, commit your changes and push that branch to Github. Then create a PR to the master of this repository with that branch.

This procedure will prevent the many "Merge remote-tracking branch 'remotes/upstream/master'" intermediate commits you see here above.