tomdesair / tus-java-server

Library to receive tus v1.0.0 file uploads in a Java server environment
MIT License
128 stars 60 forks source link

Upgrade to Spring boot 3 #50

Closed ghoshrahul closed 1 year ago

ghoshrahul commented 1 year ago

Pull request for this issue

zychu312 commented 1 year ago

@tomdesair Merge is highly anticipated. Any updates/plans on this topic?

mich9463 commented 1 year ago

Since this change would prohibit deployment to any pre Jakarta-Servlet 6.0 servlet container, like Tomcat 9, I'd propose a larger bump in version (maybe 1.1).

ksvraja commented 1 year ago

Hi @ghoshrahul I have tried the similar upgrade (for jakarta update), and did not find any need to update the logic in - src/test/java/me/desair/tus/server/creation/ITCreationExtension.java file.

Could you describe the change required for notnull --> any check.

fyi- I also faced the dateformat changes.

ghoshrahul commented 1 year ago

Hi @ksvraja ,

Along with the upgrade to spring boot 3, I have also upgraded mockito framework as well from 2.23.4 to 4.8.1

As per the mockito documentation, the notNull(Class<T> clazz) was deprecated and removed from version 3 onwards.

You can read the changes as presented in the source code

Date format changes are required, because spring has made changes to the MockHttpServletResponse class, for which the link is shared in the first comment itself.

tomdesair commented 1 year ago

Thank you @ghoshrahul for all the hard work and apologies for the late reply. I'll merge your changes, give this project's CI/CD a refresh and get a new release out of the door.

ghoshrahul commented 1 year ago

Thanks @tomdesair .

Looking forward to the next release of the tus-java-server :)

gagniou commented 1 year ago

hi,

do you have any idea when will the release take place ? I am waiting the 1.0.0-3.0 for a project in springboot 3

tomdesair commented 1 year ago

This has now been released to Maven Central as version 1.0.0-3.0: https://repo1.maven.org/maven2/me/desair/tus/tus-java-server/1.0.0-3.0/