search

tomdodd4598 / NuclearCraft

NuclearCraft is a Forge mod for Minecraft 1.12.2.
https://www.curseforge.com/minecraft/mc-mods/nuclearcraft-overhauled
MIT License
196 stars 127 forks source link

GasHelper capabilities performance #531

Closed Sir-Will closed 5 years ago

Sir-Will commented 5 years ago

Any chance this can be done without getDefaultInstance? NuclearCraft-2.16f-1.12.2

tomdodd4598 commented 5 years ago

Possibly - it will still require reflection though, which is always going to be slow. Unfortunately Mek does not include its gas capabilities in the API, so I have to get them through this slightly bizarre method.

Suppose I could ask if they could move it.

tomdodd4598 commented 5 years ago

Talked to the Mek devs - I can use a feature of Forge capabilities that I had forgotten about to get the capability much more effectively. Will sort it out for the next build :)

tomdodd4598 commented 5 years ago

Sorted :)