search

tomduck / pandoc-eqnos

A pandoc filter for numbering equations and equation references.
GNU General Public License v3.0
221 stars 27 forks source link

id attribute gets lost when output type is epub3 #37

Closed cplerch closed 5 years ago

cplerch commented 5 years ago

Although all references are rendered correctly in the output document, all equation ids are missing in epub3 output. However, when I convert the very same source files to html output everything works as expected. I'm using pandoc 2.7 with pandoc-eqnos 1.3.0

tomduck commented 5 years ago

Hi, Christian. Thanks for your feedback. I am able to reproduce this issue. Interestingly, links to figures seem to work just fine. I will look into it. Cheers, Tom.

tomduck commented 5 years ago

I just posted a new version which fixes the problem. If you have any difficulty with it, please go ahead and re-open this issue. Thanks again for your feedback, which is much appreciated.

cplerch commented 5 years ago

Thanks for the fix. After testing it there is a minor issue still remaining. It works as expected for fmt='epub' but for fmt='epub3' the id attributes are still missing. The behavior for both of these output formats should be equivalent, because they can be used synonymously. Didn't test fmt='epub2' however; maybe same problem.

cplerch commented 5 years ago

Checked again and just realized that: If you convert to output format "epub" (instead of "epub3") you now get all equations numbered twice, like this: 1558100449691 Using output format "epub3" you get: 1558100922906 which isn't optimal but at least acceptable (will open another issue for proposing a solution for rendering the equation number on the right margin, where it belongs).

tomduck commented 5 years ago

Yep, I saw that too and have a fix for it. I will be pushing out a new version shortly.

It looks like epub infers the figure number from the id in the surround span. Interesting.

tomduck commented 5 years ago

I pushed out a new version. Please give it a try and let me know what you think.

cplerch commented 5 years ago

I'm afraid the numbering still doesn't work as expected, however the original subject of THIS issue (id attributes) is OK. I will create a new issue or the numbering problem I'm experiencing.