tomduck / pandoc-secnos

A pandoc filter for numbering section references.
GNU General Public License v3.0
18 stars 5 forks source link

Check for exe breaks pip install #6

Open FaustinCarter opened 3 years ago

FaustinCarter commented 3 years ago

This check in setup.py for presence of the pandoc-secnos executable breaks local installs with pip.

https://github.com/tomduck/pandoc-secnos/blob/1cf95f8bc05657a44ac9f34d4a2c27c794c097d0/setup.py#L67-L74

In other words, running pip install . (or pip install -e .) from repository root will error out with:

    ERROR: `pandoc-secnos` script not found. This will need to
    be corrected.  If you need help, please file an Issue at
    https://github.com/tomduck/pandoc-secnos/issues.

    ----------------------------------------
ERROR: Command errored out with exit status 4294967295: python setup.py egg_info Check the logs for full command output.

It's true that one can do python setup.py develop for a local editable install, but using pip is pretty standard and ought to be supported. Is there a particularly good reason that this check should live in setup.py and not in the primary module?