search

tomeichlersmith / denv

uniformly interact with containerized environments across runners
https://tomeichlersmith.github.io/denv/
GNU General Public License v3.0
8 stars 2 forks source link

Check executable might not be available on all platforms #87

Closed EinarElen closed 7 months ago

EinarElen commented 7 months ago

Describe the bug Running denv check on a MacOs system is likely to result in 

sh: 1: check: not found

since check isn't installed by default. This can be resolved by the user installing it (e.g. brew install check), but it might be worth working around to make denv easier to use for people

EinarElen commented 7 months ago

Or maybe this is a different issue... check doesn't seem to be a part of denv anymore but is part of the README

tomeichlersmith commented 7 months ago

So, check should be a sub-command that just runs some extra shell stuff:

https://github.com/tomeichlersmith/denv/blob/e23273fe081138c7b76a23ca13d9ef7e6ac90550/denv#L917

It was very recently introduced, it is not within denv v0.5.0. You could either skip this check or use <curl install> | sh -- --next to install from the HEAD of main.

EinarElen commented 7 months ago

Right, I don't really mind just wanted to highlight the README discrepancy on main :)

tomeichlersmith commented 7 months ago

Yep :+1: Thank you, I need to think more about how to keep the docs from getting out of sync with the latest version.

tomeichlersmith commented 7 months ago

Alright, I made a new release which will allow for the installed version and what is documented on the README to be in sync. I think I just need to be more cognizant of the fact that anything that changes the CLI (especially anything changing basic usage shown in the README) mandates a new release so that installers do end up in this situation.