search

tomer8007 / kik-bot-api-unofficial

Python API for writing unoffical Kik bots that act like humans
MIT License
128 stars 77 forks source link

remove custom logging configuration #158

Closed 3dik closed 4 years ago

3dik commented 4 years ago

See the commit message for the rationale.

If you want to keep the two handlers etc., I suggest that we move that stuff to a public method set_up_dev_logging or something like that. Either way, in my opinion, not touching the logging configuration should at least be the default behavior.

tomer8007 commented 4 years ago

OK, I get what you're saying. Can you just make echo_bot.py's default logging level set to INFO? I like verbose reporting for starters.

3dik commented 4 years ago

Sure, no problem. But are you sure that you mean INFO? Note that, in the other two example scripts, the log level is set to DEBUG.

tomer8007 commented 4 years ago

Well, in DEBUG you see the raw XML that is sent, maybe this is too much. Anyway, these are the current logging levels of the examples (so no need to change them I think).

3dik commented 4 years ago

Got it. I forgot that the removed log_level argument had a default value INFO.