tomer8007 / kik-bot-api-unofficial

Python API for writing unoffical Kik bots that act like humans
MIT License
128 stars 77 forks source link

feat(docker): add bootstrapper to run bots in docker #224

Closed sokkit-io closed 1 year ago

tomer8007 commented 1 year ago

Thank you for this.

  1. Do we really have to make a BootstrapBot that's a copy of the EchoBot or can we somehow use the original EchoBot?
  2. Maybe rename bootstrap_bot.py to docker_bootstrap_bot.py?
sokkit-io commented 1 year ago

I will take a look at refactoring docker_bootstrapper.py a bit to support the existing EchoBot.

To remove the BootstrapBot I can refactor EchoBot to support loading environment variables from the configuration package I added before it instantiates the KikClient. That should allow the docker container to pass values from .env to EchoBot (or any bot implementation) so that everything plays nice in the container.

Leave the PR open if you don't mind. I'll have changes ready later tonight or sometime this weekend.

tomer8007 commented 1 year ago

Sure, I'll leave it open. Maybe you can have a wrapper class for EchoBot that would use the environment variables to initiate an EchoBot or something like that?

tomer8007 commented 1 year ago

Alright