tomer8007 / whatsapp-web-incognito

A Chrome extension that disables read receipts and presence updates on WhatsApp Web
MIT License
312 stars 74 forks source link

"Failed to restore message" #146

Closed justanotheranonymoususer closed 7 months ago

justanotheranonymoususer commented 9 months ago

Looks like it's no longer able to restore deleted message

image

tomer8007 commented 9 months ago

It seems WhatsApp made the XMPP acknowledgments mechanism more robust and added something called LID. Looking. I can get restored messages when they get deleted while the WhatsApp window is open, though.

tomer8007 commented 9 months ago

OK, I committed a8ff5fc47bdbc82f1fe16b5218c633d41ccbe214 which seems to make the message restore feature work fine for me now. Please let me know if this changes stuff for you too.

BTW some changes that WhatsApp made are for integration with third party messaging apps.

justanotheranonymoususer commented 9 months ago

Still doesn't work for me sadly. ver 2.1.0, does it contain the fix?

tomer8007 commented 9 months ago

It should :-( Javascript errors? Also I'm talking about the restore of new messages, of course.

justanotheranonymoususer commented 9 months ago

Also I'm talking about the restore of new messages, of course.

yes sure

lots of errors:

image

tomer8007 commented 9 months ago

Ah, I see. I hope to encounter this error in the upcoming days. If you feel like debugging in the meantime you can enable WAdebug = true and try to see for yourself if the revoke message is really the one that fails decryption.

justanotheranonymoususer commented 9 months ago

It stops here on every msg I receive. Not sure what else I can debug, lmk. image

tomer8007 commented 9 months ago

Does the Cannot convert undefined or null to object exception happen for messages from all contacts/groups? Did you try other accounts/re-logging in? I ask because for me it works.

justanotheranonymoususer commented 9 months ago

Does the Cannot convert undefined or null to object exception happen for messages from all contacts/groups?

Yes, seems like it

Did you try other accounts/re-logging in? I ask because for me it works.

I don't have other accounts, cleared all data of web.whatsapp.com and logged in from start but same errors still

aviv926 commented 8 months ago

Is there any new information about this? For me it doesn't even show the message Failed to restore message

Also, thanks for this amazing project and the investment of time in its development

tomer8007 commented 8 months ago

@aviv926 Sadly there is no new information because this feature works for me. I also tried with WA Web Plus enabled too. Thanks for the warm words though

Do you get the same error as @justanotheranonymoususer ?

aviv926 commented 8 months ago

@aviv926 Sadly there is no new information because this feature works for me. I also tried with WA Web Plus enabled too. Thanks for the warm words though

Do you get the same error as @justanotheranonymoususer ?

This might not be such a smart question on my part, but are you using the published version in the repository here? I'm assuming you're using git so I guess this question doesn't make much sense.

thank you for the answer

justanotheranonymoususer commented 8 months ago

I've installed it from the extension store, not from the repo

On Wed, Oct 18, 2023, 20:18 aviv926 @.***> wrote:

@aviv926 https://github.com/aviv926 Sadly there is no new information because this feature works for me. I also tried with WA Web Plus enabled too. Thanks for the warm words though

Do you get the same error as @justanotheranonymoususer https://github.com/justanotheranonymoususer ?

This might not be such a smart question on my part, but are you using the published version in the repository here? I'm assuming you're using git so I guess this question doesn't make much sense.

thank you for the answer

— Reply to this email directly, view it on GitHub https://github.com/tomer8007/whatsapp-web-incognito/issues/146#issuecomment-1768997231, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMDRPC7KKPIXIPKEU5OYP3YAAFNTAVCNFSM6AAAAAA5NQPHZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYHE4TOMRTGE . You are receiving this because you were mentioned.Message ID: @.***>

tomer8007 commented 8 months ago

I'm using the version from the git repository.

aviv926 commented 8 months ago

I'm using the version from the git repository.

I seem to have figured out what the problem is When the WhatsApp interface is in a language other than English, the message "Failed to restore messages" is not displayed as soon as you change the language to English, the message "Failed to restore messages" is displayed but is not yet restored

Could you please specify what your setup is? What language interface? And what is the version of your WhatsApp? Also are you running the extension on chrome?

It is important for me to note that in previous versions it worked without a problem with a system interface that is not English Thanks

tomer8007 commented 8 months ago

I tested it on both English and non-english setups, and yes, I'm using chrome. However I just encountered the following error which I think is the same error you're getting:

image

aviv926 commented 8 months ago

I tested it on both English and non-english setups, and yes, I'm using chrome. However I just encountered the following error which I think is the same error you're getting:

image

Does this mean there is a problem with the extension? Or does it have nothing to do with it and the problem is on my side and not in the extension? Sorry, I didn't quite understand

tomer8007 commented 8 months ago

I'm sure there is a problem with the extension, I just need to reproduce it.

tomer8007 commented 7 months ago

@aviv926 @justanotheranonymoususer Can you tell if the newer version fixes the restore of messages?

justanotheranonymoususer commented 7 months ago

Yes it seems to be working now, thanks! FWIW there are still errors in the console from interception.js:710, not sure if it's a real problem

On Mon, Nov 27, 2023 at 12:37 AM Tomer @.***> wrote:

@aviv926 https://github.com/aviv926 @justanotheranonymoususer https://github.com/justanotheranonymoususer Can you tell if the newer version fixes the restore of messages?

— Reply to this email directly, view it on GitHub https://github.com/tomer8007/whatsapp-web-incognito/issues/146#issuecomment-1826921900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMDRPAHAGLO4JR6EZHG56TYGPAELAVCNFSM6AAAAAA5NQPHZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWHEZDCOJQGA . You are receiving this because you were mentioned.Message ID: @.***>

tomer8007 commented 7 months ago

OK, if it looks like a real problem you can open another issue for it