search

tomer8007 / whatsapp-web-incognito

A Chrome extension that disables read receipts and presence updates on WhatsApp Web
MIT License
312 stars 74 forks source link

Added Safari Extention #63

Open taksh108 opened 2 years ago

taksh108 commented 2 years ago

Safari extention added. Works for group Chats but not for Individual chats

tomer8007 commented 2 years ago

Is there any way to prevent the code duplication? Also do you have an idea of why it doesn't work for individual chats? Do you have a stack trace?

taksh108 commented 2 years ago

I actually started learning about making extensions about 24 hours ago, so at this time, I really don't know how to answer your questions. This, and SpotiAds are my first commits to github

taksh108 commented 2 years ago

Also, the feature seems to be working fine on both individual and group chats. I must've not tested correctly previousl

Screenshot 2021-11-02 at 1 55 48 AM

y

tomer8007 commented 2 years ago

This looks good, I think the only problem is the duplication of code files. If you can find a way to not need that and still have the same repo for both Chrome and Safari it'd be great. If not, we can just have a link to your fork for those who want Safari support. The same is true for SpotiAds.

taksh108 commented 2 years ago

I have figured out to package It into a single binary so that we only need share only 1 file, but I am not sure if it will work for everyone. It runs on my computer as I built it, but since I am not enrolled in Apple's Paid Developer program, Binaries signed by me might not work for others. Will update once I have researched more. Also, you can check out the directory structure of https://github.com/ajayyy/SponsorBlock as they have all extensions in one repo. Tho the Distribution method is quite different