search

tomerfiliba-org / reedsolomon

⏳🛡 Pythonic universal errors-and-erasures Reed-Solomon codec to protect your data from errors and bitrot. Includes a future-proof zero-dependencies pure-python implementation 🔮 and an optional speed-optimized Cython/C extension 🚀
http://pypi.python.org/pypi/reedsolo
Other
351 stars 86 forks source link

Remove useless shebang line in non-script source reedsolo.py #31

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 3 years ago

Remove useless shebang line in non-script source reedsolo.py.

henryiii commented 1 year ago

FWIW, Ruff checks for this, see https://scikit-hep.org/developer/style. Though making it work on Python 2 dual-compatible code is extra work, some things have to be disabled to do that.

lrq3000 commented 1 year ago

Thank you @musicinmybrain for your PR, it's now merged in https://github.com/tomerfiliba-org/reedsolomon/commit/d9b0bc06228d88495258f8e8bf5284ad5a7b11e8 !

@henryiii Thank you for the suggestion! Ruff sounds very interesting, I am very interested in code style normalizers, but unfortunately I did not yet find one that works with Cython, and I would like to keep a similar styling between both the .py and .pyx since they implement the same things. If you know a tool that supports Cython I would be delighted to try!