tomerfiliba / plumbum

Plumbum: Shell Combinators
https://plumbum.readthedocs.io
MIT License
2.82k stars 184 forks source link

added TypedEnv, for easy parsing of env-vars #451

Closed koreno closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.05%) to 82.408% when pulling 73ca0176d1cdf6665e19d694806d5e9c6ed3a360 on typed-env into d2b7b16c7490a806b027d9e593f8f41072f54098 on master.

henryiii commented 5 years ago

Python 2 support, please. We haven't dropped Python 2.6 yet, though that's planned for 1.7. A future 2.0 could drop Python 2 support. Since Plumbum is a scripting helper, it should work with any system Python, and CentOS 7 still is on 2.6, macOS is on 2.7 (until it drops all scripting languages in a release or two, anyway).

henryiii commented 5 years ago

I think you could just move the ** test into a test marked with Python3 only.

henryiii commented 5 years ago

Would you be interested in writing docs/changelog for this and the other additions you've just made? If not I will, but it would be slightly delayed, probably.

koreno commented 5 years ago

@henryiii - should I merge this?

henryiii commented 5 years ago

It’s okay, I can. Have been busy so ping me as needed (like you did).