tomerfiliba / plumbum

Plumbum: Shell Combinators
https://plumbum.readthedocs.io
MIT License
2.82k stars 184 forks source link

Better documented behavoir for override, drop overwrite #462

Closed henryiii closed 5 years ago

henryiii commented 5 years ago

Fixes #245. Please comment on whether this is a good plan, or provide suggestions.

Same behavior as current Plumbum if no arguments supplied.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.02%) to 82.498% when pulling eeb07bb933262e22a9645255a20a08c724066662 on henryiii-override into 456d2c30624873e5deaa7d26aad432e2bb288ebd on master.

AndydeCleyre commented 5 years ago

Here there is a mismatch in base.py:

def copy(self, dst, override=False):

Will silently fail to copy if override is None (the default).