search

tomerfiliba / plumbum

Plumbum: Shell Combinators
https://plumbum.readthedocs.io
MIT License
2.8k stars 182 forks source link

Allow passing kwargs to paramiko client #564

Closed YairHalberstadt closed 2 years ago

YairHalberstadt commented 2 years ago

Currently it's impossible to pass a socks proxy to a ParamikoMachine, even though paramiko supports that.

By chaining kwargs through to the paramiko client, we expose the full functionality of paramiko to the user.

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.004%) to 82.388% when pulling 32f1c58c6a3b0e07c9532634f7d9d2918a1b6e0a on YairHalberstadt:patch-1 into 731e7e03adfa6afdbce05e825ca42811090618cb on tomerfiliba:master.

henryiii commented 2 years ago

Why did you close this?

YairHalberstadt commented 2 years ago

I realized there was some functionality missing that meant passing a socks proxy still wouldn't work. I can't remember what exactly it was right now because I tried about a month ago.

henryiii commented 2 years ago

Okay. Sorry for the delay, just now working out a few issues in the CI.

YairHalberstadt commented 2 years ago

No problem! Thanks for all your hard work - I love plumbum!