search

tomerfiliba / plumbum

Plumbum: Shell Combinators
https://plumbum.readthedocs.io
MIT License
2.78k stars 182 forks source link

Fix missing non-zero return code from TEE'd pipe #661

Closed vient closed 8 months ago

vient commented 8 months ago

I checked that modified test is failing, and fix in this branch makes it green.

Fixes #660

coveralls commented 8 months ago

Coverage Status

coverage: 84.489% (+0.03%) from 84.464% when pulling 4c5ea87df12e89863db8e8c1872632ef32113006 on vient:vient/fix-tee-pipe-retcode into 40fcd2708863d36fb570be4ca19c14d2457ab7b7 on tomerfiliba:master.

vient commented 8 months ago

Wat

Looks like linter is broken in CI, I've run nox locally, all checks passed.

henryiii commented 8 months ago

Yeah, I think it is. Will look at it when on a computer.

vient commented 8 months ago

Btw, nox is great. I did not know what it is, installed it, and it just worked from the first try, and ran all tests? Super cool

henryiii commented 8 months ago

See https://learn.scientific-python.org/development/guides/tasks/ - I love it. :)

I see what's wrong - we've pinned an old pylint, and it doesn't support Python 3.12, which is what the default is now. I'm fixing that in a separate PR.