search

tomeshnet / mesh-orange

A small ramdisk system running modern Debian to support mesh networking on ARM single-board computers
https://tomeshnet.github.io/mesh-orange/
GNU General Public License v2.0
39 stars 7 forks source link

Update docs on persistent configurations #29

Closed benhylau closed 6 years ago

benhylau commented 6 years ago

Sync up with: https://github.com/hamishcoleman/debian-minimal-builder/blob/master/README#L73

hamishcoleman commented 6 years ago

Rather than repeating things, wouldnt it make more sense to say something like "for details on how the persistent configuration works, read the file xyx in project abc (or URL)" ?

benhylau commented 6 years ago

@hamishcoleman can we merge this?

hamishcoleman commented 6 years ago

Sure - I thought you were doing merging.

Also, you might want to look into squashing commits for branches that are not cumulative changes (like this one)

benhylau commented 6 years ago

Sure - I thought you were doing merging.

Yes but you gotta approve it first :)

benhylau commented 6 years ago

Squashed in https://github.com/tomeshnet/mesh-orange/pull/35

hamishcoleman commented 6 years ago

Another thing - you dont need to create a new pull request with the squashed (or otherwise rewritten) branch. You can just force push over the top of the existing branch and github handles that fine.