search

tomeshnet / mesh-orange

A small ramdisk system running modern Debian to support mesh networking on ARM single-board computers
https://tomeshnet.github.io/mesh-orange/
GNU General Public License v2.0
39 stars 7 forks source link

Deploy build artifacts to github releases and docs to github pages on… #59

Closed benhylau closed 5 years ago

benhylau commented 5 years ago

… tag

benhylau commented 5 years ago

Releases: https://github.com/tomeshnet/mesh-orange/releases Pages: https://tomeshnet.github.io/mesh-orange/

@hamishcoleman perhaps we should not publish the licheepi, the file is 1 GB. Thoughts?

benhylau commented 5 years ago

Yea I don't think GitHub cares too much at the moment https://help.github.com/articles/distributing-large-binaries/ let's keep all of the images

benhylau commented 5 years ago

@hamishcoleman another review? https://github.com/tomeshnet/mesh-orange/releases/tag/v0.11 Let's merge this soon.

hamishcoleman commented 5 years ago

There appear to be a lot of false starts and reverts in this branch - do you know how to edit history and squash commits? There is also at least one commit that has multiple different changes in it, which would be clearer if it was split into functional changes.

benhylau commented 5 years ago

I plan to use the GitHub Squash and Merge to make this into one single commit that adds CI to GitHub Releases and GitHub Pages. I am generally less picky about commit history though.

hamishcoleman commented 5 years ago

Squashing every commit into one does not make much sense to me. Especially since there are multiple distinct changes occurring that would benefit from being able to be individual separated and tested. Just going on my memory - there are whitespace changes, test environment changes, documentation changes as well as "add deploy" - these should all be separate commits

benhylau commented 5 years ago

60 ports all changes with refactored commits.

There are a bunch of release tags that are pointing to commits in this PR, which will no longer exist after #60 is merged and this branch is deleted. What shall we do about those?

This one line change is not ported since I don't find documentation on one over another.

benhylau commented 5 years ago

I have release artifacts published and addressed multiple rounds of review comments without outstanding issues, but this patch has been sitting here without further feedback. @hamishcoleman please provide next steps or timeline to merge?