Host Fonts Locally - Githubissues

tomeshnet / p2p-internet-workshop

Building the Peer-to-Peer Internet workshop series

https://tomeshnet.github.io/p2p-internet-workshop/

Creative Commons Attribution Share Alike 4.0 International

99 stars 17 forks source link

Host Fonts Locally #83

Closed Shrinks99 closed 5 years ago

Shrinks99 commented 5 years ago

Fonts are not hosted locally for the markdown to PDF conversion or Remark. This should really be done to allow everything to be built without internet access.

benhylau commented 5 years ago

@Shrinks99 it's not a bug if it's a missing feature in a branch that hasn't been merged. The current version works just fine without Internet access. And as I have pointed out "markdown to PDF conversion" can have build-time Internet dependencies, just not the local presentation website.

benhylau commented 5 years ago

This would better belong as a subtask in the "gitbook -> remark" conversion itself. I suggest to move and close so it doesn't confuse users of current release.

Shrinks99 commented 5 years ago

Alrighty