tomfran / typo

A simple Hugo theme
https://tomfran.github.io/
MIT License
247 stars 76 forks source link

feat: Content License and Copyright holder as Footer #24

Closed arunmathaisk closed 2 months ago

arunmathaisk commented 2 months ago
[params]
showFooterLicense = true
licenseType = "CC BY-SA 4.0"
copyrightYear = "2024"
copyrightHolder = "Arun Mathai"
Screenshot 2024-09-14 at 12 37 16 AM

Solves #25

tomfran commented 2 months ago

Thank you for the pull request! I like the idea of your footer, but I think a more generic implementation would be better.

Something like:

[params]
showFooter = true|false // default to true
footerContent = "Custom MD footer content."

So basically the same we are doing for home intro content.

This would allow users to have a custom footer (something I am seeing a lot in the forks) and decide to hide it completely if needed.

Also, I don't like the idea of having two footer files, one with some logic would be more than enough.

arunmathaisk commented 2 months ago

Makes sense.

tomfran commented 2 months ago

If you want to make those changes feel free to update the PR 👍

arunmathaisk commented 2 months ago
[params]
showFooter = true
footerContent = """
Hahahahah
"""

Example:

image

@tomfran Hope this is what you wanted :)

tomfran commented 2 months ago

This looks good, but the showFooter param must default to true for this change to be backward compatible. So something like: if the param is not set or it's true, then show the footer.

arunmathaisk commented 2 months ago

Lol. forgot about backward compatibility. Glad to see you care about it :) Here take a look https://github.com/tomfran/typo/pull/24/commits/ef9948b2aee58dc785bfbb844f8e18d219b913fa