search

tomgenoni / ouroboros

CSS spinner for modern browsers, built with Sass.
http://atomeye.com/projects/sass-css-spinner.html
399 stars 15 forks source link

Few comments #4

Open evgenyus opened 11 years ago

evgenyus commented 11 years ago

Spinners are awesome, just few thoughts:

1) I wouldn't assume everyone is using SASS - customization should be easy with pure CSS. Right now, I need to change 6 numbers - width and height of a spinner, a hole, and left/right hole positions. More universal solution would be to set hole's width and height to 60%, with top position at 20%, and non-absolute position. No need to round((strip-units($size)*.6)) with SASS. Less calculations is better. Plus, there are mobile developers who like to size everything with rems (not pixels) and then change font-size based on, say, screen width.

2) The only prefix you need these days is -webkit. Firefox crowd is updating their browsers super fast, and FF dropped vendor prefixes with version 16. http://caniuse.com/#search=css-animation

tomgenoni commented 11 years ago

Thanks for your comments. I'm going to revisit the HTML/CSS for this shortly and will take these into account.

TitoAgudelo commented 9 years ago

In screen resolution better can see a line Animation showing up an unwanted mark at the 6 o'clock position do you have any solution thanks and good job