search

tomhollander / PowerwallCompanion

Windows UWP app for monitoring your Tesla Powerwall 2 battery
9 stars 7 forks source link

Fix time zone issue #18

Closed briangru closed 6 months ago

briangru commented 6 months ago

Fix a typo that prevented retrieving the installation time zone. Make sure a double calculation is done using doubles.

tomhollander commented 6 months ago

Thanks for the PR @briangru! I'm hoping to do a new release in the next week, will make sure to incorporate these changes. I have a bunch of pending changes so I may apply your changes manually (but will keep the PR open until then as a reminder).

briangru commented 6 months ago

Sounds great. This is a neat app.

From: Tom Hollander @.> Sent: Sunday, March 3, 2024 3:03:34 PM To: tomhollander/PowerwallCompanion @.> Cc: briangru @.>; Mention @.> Subject: Re: [tomhollander/PowerwallCompanion] Fix time zone issue (PR #18)

Thanks for the PR @briangruhttps://github.com/briangru! I'm hoping to do a new release in the next week, will make sure to incorporate these changes. I have a bunch of pending changes so I may apply your changes manually (but will keep the PR open until then as a reminder).

— Reply to this email directly, view it on GitHubhttps://github.com/tomhollander/PowerwallCompanion/pull/18#issuecomment-1975325144, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWH72D6ED44D6FCADANHS3YWOF2NAVCNFSM6AAAAABEDYN7O2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGMZDKMJUGQ. You are receiving this because you were mentioned.Message ID: @.***>

tomhollander commented 6 months ago

Incorporated these fixes in the 6.2 release.