search

tomholub / coinbaseorders

Coinbase Limit Orders app
coinbaseorders.com
22 stars 11 forks source link

Add Coinbase balance and outstanding order balances to orders page #2

Closed MattFaus closed 10 years ago

MattFaus commented 10 years ago

My text editor automatically removes extra whitespace at the end of lines.

Here is a screenshot of what this looks like. Note the available balance can go negative because the page does not check of sufficient funds when setting up a sell order.

screen shot 2014-02-26 at 8 23 46 pm

Also, now that I'm taking another look at it, it would be nice to add a 3rd column which displays the price in USD.

tomholub commented 10 years ago

Hi, thanks, I'll be able to get to it hopefully tomorrow and I will merge it and deploy. I'll also list you as one of the developers on the website if you want to, let me know what info would you like displayed

Tom Holub http://holub.me/, (323) 592-9554

On Wed, Feb 26, 2014 at 8:25 PM, Matt Faus notifications@github.com wrote:

My text editor automatically removes extra whitespace at the end of lines.

Here is a screenshot of what this looks like. Note the available balance can go negative because the page does not check of sufficient funds when setting up a sell order.

[image: screen shot 2014-02-26 at 8 23 46 pm]https://f.cloud.github.com/assets/2415796/2279187/17240876-9f67-11e3-9c09-0b56b8b62cf6.png

Also, now that I'm taking another look at it, it would be nice to add a

3rd column which displays the price in USD.

You can merge this Pull Request by running

git pull https://github.com/MattFaus/coinbaseorders master

Or view, comment on, or merge it at:

https://github.com/tomholub/coinbaseorders/pull/2 Commit Summary

  • Add some tips for getting things setup on on Mac OS X
  • Add Coinbase balance and outstanding order balances to orders page

File Changes

  • M README.txthttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-0(10)
  • M www/app/model/DB/OrdersModel.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-1(20)
  • M www/app/presenters/BasePresenter.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-2(12)
  • M www/app/presenters/HomepagePresenter.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-3(15)
  • M www/app/templates/Homepage/orders.lattehttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-4(28)
  • A www/www/css/orders.csshttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-5(17)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/tomholub/coinbaseorders/pull/2 .

MattFaus commented 10 years ago

Sure, that'd be cool! You can just put "Matt Faus | dev@outlook.com" down. I'll let you know before I start working on anything else, to be sure we do not collide.

Date: Wed, 26 Feb 2014 23:13:13 -0800 From: notifications@github.com To: coinbaseorders@noreply.github.com CC: dev@outlook.com Subject: Re: [coinbaseorders] Add Coinbase balance and outstanding order balances to orders page (#2)

Hi, thanks, I'll be able to get to it hopefully tomorrow and I will merge

it and deploy. I'll also list you as one of the developers on the website

if you want to, let me know what info would you like displayed

Tom Holub http://holub.me/, (323) 592-9554

On Wed, Feb 26, 2014 at 8:25 PM, Matt Faus notifications@github.com wrote:

My text editor automatically removes extra whitespace at the end of lines.

Here is a screenshot of what this looks like. Note the available balance

can go negative because the page does not check of sufficient funds when

setting up a sell order.

[image: screen shot 2014-02-26 at 8 23 46 pm]https://f.cloud.github.com/assets/2415796/2279187/17240876-9f67-11e3-9c09-0b56b8b62cf6.png

Also, now that I'm taking another look at it, it would be nice to add a

3rd column which displays the price in USD.

You can merge this Pull Request by running

git pull https://github.com/MattFaus/coinbaseorders master

Or view, comment on, or merge it at:

https://github.com/tomholub/coinbaseorders/pull/2

Commit Summary

  • Add some tips for getting things setup on on Mac OS X
  • Add Coinbase balance and outstanding order balances to orders page

File Changes

  • M README.txthttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-0(10)
  • M www/app/model/DB/OrdersModel.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-1(20)
  • M www/app/presenters/BasePresenter.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-2(12)
  • M www/app/presenters/HomepagePresenter.phphttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-3(15)
  • M www/app/templates/Homepage/orders.lattehttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-4(28)
  • A www/www/css/orders.csshttps://github.com/tomholub/coinbaseorders/pull/2/files#diff-5(17)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/tomholub/coinbaseorders/pull/2

.

— Reply to this email directly or view it on GitHub.

tomholub commented 10 years ago

Hi, Sorry I didn't deploy it today, I'll get to it soon. Tom

On Thursday, February 27, 2014, Matt Faus notifications@github.com wrote:

Sure, that'd be cool! You can just put "Matt Faus | dev@outlook.comjavascript:_e(%7B%7D,'cvml','dev@outlook.com');" down. I'll let you know before I start working on anything else, to be sure we do not collide.

Date: Wed, 26 Feb 2014 23:13:13 -0800 From: notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com'); To: coinbaseorders@noreply.github.comjavascript:_e(%7B%7D,'cvml','coinbaseorders@noreply.github.com'); CC: dev@outlook.com javascript:_e(%7B%7D,'cvml','dev@outlook.com'); Subject: Re: [coinbaseorders] Add Coinbase balance and outstanding order balances to orders page (#2)

Hi, thanks, I'll be able to get to it hopefully tomorrow and I will merge

it and deploy. I'll also list you as one of the developers on the website

if you want to, let me know what info would you like displayed

Tom Holub http://holub.me/, (323) 592-9554

On Wed, Feb 26, 2014 at 8:25 PM, Matt Faus notifications@github.com<javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

My text editor automatically removes extra whitespace at the end of lines.

Here is a screenshot of what this looks like. Note the available balance

can go negative because the page does not check of sufficient funds when

setting up a sell order.

[image: screen shot 2014-02-26 at 8 23 46 pm]< https://f.cloud.github.com/assets/2415796/2279187/17240876-9f67-11e3-9c09-0b56b8b62cf6.png>

Also, now that I'm taking another look at it, it would be nice to add a

3rd column which displays the price in USD.

You can merge this Pull Request by running

git pull https://github.com/MattFaus/coinbaseorders master

Or view, comment on, or merge it at:

https://github.com/tomholub/coinbaseorders/pull/2

Commit Summary

  • Add some tips for getting things setup on on Mac OS X
  • Add Coinbase balance and outstanding order balances to orders page

File Changes

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/tomholub/coinbaseorders/pull/2>

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/tomholub/coinbaseorders/pull/2#issuecomment-36293991 .

Tom James Holub http://holub.me/, (323) 592-9554