search

tomholub / coinbaseorders

Coinbase Limit Orders app
coinbaseorders.com
22 stars 11 forks source link

Add confirmation for orders that will execute immediately. #5

Closed MattFaus closed 10 years ago

MattFaus commented 10 years ago

Without this code, inputting a buy order > 5% of the current price or a sell order < 5% of the current price will execute the order immediately without confirmation.

Test Plan: Submit relevant orders on /homepage/new-order See the confirmation dialog pop and not pop correspondingly.

MattFaus commented 10 years ago

Actually, this should read:

"Without this code, inputting a buy order > current price + 5% or a sell order < current price - 5% will execute the order immediately without confirmation."

tomholub commented 10 years ago

It's merged & deployed, thanks :-)

Tom James Holub http://holub.me/, (323) 592-9554

On Fri, Mar 7, 2014 at 9:46 AM, Matt Faus notifications@github.com wrote:

Actually, this should read:

"Without this code, inputting a buy order > current price + 5% or a sell order < current price - 5% will execute the order immediately without confirmation."

Reply to this email directly or view it on GitHubhttps://github.com/tomholub/coinbaseorders/pull/5#issuecomment-37048594 .