Some "unused variable" warnings and failed tests.

[amiloradovsky]

Hi, I'm trying to port it to Nix(OS). It builds and installs, and the hello-world example runs well. But, first, while building I've got the following warning (nothing serious, but still):

[ 10%] Building CXX object CMakeFiles/dalec.dir/src/dale/ContextSavePoint/ContextSavePoint.cpp.o
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/src/dale/Context/Context.cpp: In member function 'dale::Function* dale::Context::getFunction(const char*, std::vector<dale::Type*>*, dale::Function**, bool, std::vector<bool>*)':
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/src/dale/Context/Context.cpp:532:15: warning: unused variable 'first_closest_fn' [-Wunused-variable]
     Function *first_closest_fn = NULL;
               ^

Yet, while running tests, it first spits out:

/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/src/include-test.dt:3:10: error: /nix/store/jqarhcapjkw49pcwr4bd077b9y4c0qfn-dale-0.1/include/dale/include-test-2.dt: No such file or directory
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/src/include-test.dt:6:17: error: variable not in scope: 'var1'
Can't exec "./include-test": No such file or directory at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/127include-all.t line 15.

#   Failed test 'Program executed successfully'
#   at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/127include-all.t line 16.
#          got: '-1'
#     expected: '0'

#   Failed test 'Got expected results'
#   at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/127include-all.t line 19.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = '1000'
rm: cannot remove 'include-test': No such file or directory
# Looks like you failed 2 tests of 3.
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/127include-all.t ....................... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/3 subtests 

and, later

/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/src/proc-include-test.dt:4:20: error: /nix/store/jqarhcapjkw49pcwr4bd077b9y4c0qfn-dale-0.1/include/dale/t/src/proc-include.dt: No such file or directory
Can't exec "./proc-include-test": No such file or directory at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/133proc-include.t line 15.

#   Failed test 'Program executed successfully'
#   at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/133proc-include.t line 16.
#          got: '-1'
#     expected: '0'

#   Failed test 'Got expected results'
#   at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/133proc-include.t line 19.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = 'test'
rm: cannot remove 'proc-include-test': No such file or directory
# Looks like you failed 2 tests of 3.
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/133proc-include.t ...................... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/3 subtests 

and, finally, crashes with

#   Failed test 'Error pattern matches actual error'
#   at /tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/999last/001compile-errors.t line 37.
#                   '/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/error-src/include-test.dt:1:10: error: /nix/store/jqarhcapjkw49pcwr4bd077b9y4c0qfn-dale-0.1/include/dale/include/test.dt: No such file or directory'
#     doesn't match '(?^:t/error-src/include/test.dt:2:2: error: 'def' requires 2 arguments \(got 3 instead\))'
# Looks like you failed 1 test of 312.
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/999last/001compile-errors.t ..................... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/312 subtests 

Test Summary Report
-------------------
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/127include-all.t                     (Wstat: 512 Tests: 3 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/001basic/133proc-include.t                    (Wstat: 512 Tests: 3 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2
/tmp/nix-build-dale-0.1.drv-0/dale-5a5fbbd815a95d669229f7ecc9154874553443d6-src/t/999last/001compile-errors.t                   (Wstat: 256 Tests: 312 Failed: 1)
  Failed test:  115
  Non-zero exit status: 1
Files=344, Tests=1364, 115 wallclock secs ( 0.80 usr  0.31 sys + 297.06 cusr 15.10 csys = 313.27 CPU)
Result: FAIL
Failed 3/344 test programs. 5/1364 subtests failed.
make[3]: *** [CMakeFiles/tests.dir/build.make:57: CMakeFiles/tests] Error 1
make[2]: *** [CMakeFiles/Makefile2:953: CMakeFiles/tests.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:960: CMakeFiles/tests.dir/rule] Error 2
make: *** [Makefile:448: tests] Error 2
builder for ‘/nix/store/5g96nw82p1qyj00w9pgmdmc85lsxgi9l-dale-0.1.drv’ failed with exit code 2
error: build of ‘/nix/store/5g96nw82p1qyj00w9pgmdmc85lsxgi9l-dale-0.1.drv’ failed

I could include the full log, but it looks normal elsewhere.

Revision: 5a5fbbd815a95d669229f7ecc9154874553443d6

The Nix expression is at https://github.com/amiloradovsky/nixpkgs/tree/dale

[amiloradovsky]

Found a way to "fix" the (three) include-related tests. About to close the issue.

[tomhrr]

Thanks for reporting, this should be fixed properly now.

[amiloradovsky]

Yes it is, merged. Thank you!