search

tomhrr / dale

Lisp-flavoured C
BSD 3-Clause "New" or "Revised" License
1.03k stars 48 forks source link

rewritten dalec #188

Closed amiloradovsky closed 7 years ago

amiloradovsky commented 7 years ago

Motivated by this issue https://github.com/tomhrr/mawled/issues/12. Mostly refactoring and minor fixes/cleanups, the behavior should stay. Tested on NixOS/amd64 and /i686.

PS: if you have any thoughts, don't hesitate to tell me early. Positive or negative -- no matter -- I'll try to explain and/or comply.

tomhrr commented 7 years ago

Thanks for submitting this. It looks good functionality-wise, particularly the removal of copyFile (not sure why that was there) and the use of std::string for constructing the compilation command. The only problems that I can see relate to project consistency, specifically with syntax (which should be 1TBS) and the use of IO streams (avoided elsewhere where possible). Unless you think it's a bad idea for some reason, I'll merge this PR and then make the necessary consistency updates afterwards?

amiloradovsky commented 7 years ago

Sure, I'd accept virtually any correction anyways, so you can fix the bits however you like. And, yes, I might indeed squeeze it a little bit too much: that's not something I'd insist on. With respect to IO streams, I personally dislike format strings even more than overloaded (I/O) operations: if I wanted to be exhaustive, I'd remove all the functions accepting format strings. But, again, that's not something I really care about in this case. So you can change that.

tomhrr commented 7 years ago

Thanks, this has been merged.