search

tomichj / invitation

A Rails gem that can send 'scoped' invitations
MIT License
77 stars 28 forks source link

String class name for configuration.user_model #9

Closed itkin closed 7 years ago

itkin commented 7 years ago

fixes #8

tomichj commented 7 years ago

Thanks! I'll take it for a spin later today, but at a quick glance it looks perfect.

I'm not quite sure how that error ever came to be. The configuration was 'borrowed' from Authenticate, which does it the right way:

https://github.com/tomichj/authenticate/blob/master/lib/authenticate/configuration.rb#L257

Not sure how I managed to screw that up.

Thanks very much for the fix.

tomichj commented 7 years ago

thanks again for catching this, and fixing it

itkin commented 7 years ago

it’s all good man was nothing, i’ll maybe have an other one for you next week to allow sti on invite model but i would like to finish the integration first to make sure i need this feature.

Thank to you for this nice gem, it really helped !

Le 1 juil. 2017 à 10:41, Justin Tomich notifications@github.com a écrit :

thanks again for catching this, and fixing it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomichj/invitation/pull/9#issuecomment-312419673, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHEaupFhKu3GY7S5AU6QxBc45HqvryBks5sJgY2gaJpZM4OGTyk.

tomichj commented 7 years ago

oops, accidentally clobbered master with an experimental script gone haywire, remerging your change, apologies

tomichj commented 7 years ago

Thanks again, pushed a new version of the gem, version 0.4.2, with your change.

I'm really glad to hear you found the gem of some use!