search

tomighty / tomighty-osx

Tomighty for macOS
https://tomighty.github.io
Apache License 2.0
309 stars 79 forks source link

Raise system notification when timer goes off #7

Closed ccidral closed 8 years ago

eduardonunesp commented 9 years ago

:+1:

eduardonunesp commented 9 years ago

Notifications implemented, if you want give a try https://github.com/eduardonunesp/tomighty-osx

dvntucker commented 8 years ago

Any PR for this should include a preference to enable/disable it.

russkel commented 8 years ago

👍 Just got this app today and was hoping someone had implemented this!

sprig commented 8 years ago

👍 @dvntucker Isn't the choice inside the notification center enough?

dvntucker commented 8 years ago

IMO, providing a preference for it is easy enough that I would prefer that any PR for this included it, because in my mind the default should be for no notifications (even though personally I want them). That being said, if someone wants to create a PR with just notifications and no preference for them I'd be willing to either release it as is, or write the preference code myself.

I even have Notifications created in my own branch, I just haven't had time to rebase it off of current develop. If someone wants to rebase it and create a PR against develop I'd be happy to merge. Otherwise I'll try to get to it ASAP:

https://github.com/dvntucker/tomighty-osx/commit/7523779b41dea26fef0c4351a97b00dac1f82eb1

dvntucker commented 8 years ago

Merged. Aiming for release 1.2, should be sometime very soon (hopefully this weekend).