tomitrescak / meteor-uploads

MIT License
295 stars 41 forks source link

validateRequest fires only after upload is completed #183

Open rteslaru opened 8 years ago

rteslaru commented 8 years ago

@tomitrescak, thanks for fixing #175!

I ran some tests and I find that validateRequest(req) fires after the upload is completed, not before. It is perhaps easy to miss if testing locally since the upload is so fast. I recommend either deploying somewhere and uploading a reasonably large file, or just upload a huge file locally to see it in action.

Either way, validateRequest(req) waits for upload to be completed before firing.

Hope this makes sense, let me know if you have any questions, and thanks a lot!