search

tomitribe / beryllium

Apache License 2.0
6 stars 6 forks source link

Issue #11 - Log requests and responses to SL4J logger #10

Closed jromero closed 7 years ago

jeanouii commented 7 years ago

Thanks for the contribution

cchacin commented 7 years ago

@jromero Thanks a lot for your contribution 👍 , the build was failing because the following errors:

[ERROR] src/main/java/org/tomitribe/beryllium/rest/RestSteps.java:[51,27] (naming) StaticVariableName: Name 'LOGGER' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR] src/main/java/org/tomitribe/beryllium/internal/logging/LoggerPrintStream.java:[61,7] (coding) MissingSwitchDefault: switch without "default" clause.

I'll fix that in a separate PR, but I'll change the github project configuration to avoid merges without passing the checks 🛑