Added `Default` instances for `Const`, `Identity` and `Tagged` values inside `Maybe`s and `[]`s

tomjaguarpaw / product-profunctors

Other

19 stars 14 forks source link

Added `Default` instances for `Const`, `Identity` and `Tagged` values inside `Maybe`s and `[]`s #23

Closed duairc closed 7 years ago

duairc commented 7 years ago

I've no idea if you "agree" with these instances or want to see them included, but they've proved useful in my own code that uses Opaleye, but obviously they're orphans, so it would be good to upstream them if possible.

tomjaguarpaw commented 7 years ago

Thanks. It'll be a while before I can look at these due to the holiday season, etc.. Feel free to ping me if you think I'm leaving this for too long.

duairc commented 7 years ago

I've done some refactoring in my code and basically I no longer need these instances, so I don't think you should merge them. However, I now have a new pull request (#24) that has other instances instead.