search

tomjaguarpaw / product-profunctors

Other
19 stars 14 forks source link

Allow record types of any size #25

Closed tomjaguarpaw closed 7 years ago

tomjaguarpaw commented 7 years ago

This should work for both record types and non record types.

domenkozar commented 7 years ago

cc @folsen (for opaleye-gen that now uses fieldsname branch)

tomjaguarpaw commented 7 years ago

@folsen: I'm planning to merge this into master. fieldnames was just a proof of concept that broke support for non record types! This branch workn for both. If anyone can confirm that it works sensibly -- with opaleye-gen or otherwise -- then I'll merge.

domenkozar commented 7 years ago

I can confirm that opaleye-gen compiles, but haven't ran anything yet.

tomjaguarpaw commented 7 years ago

If it compiles it works :) though we should probably wait until it's tested on a table of more than 61 columns since that was the original use case.

folsen commented 7 years ago

Compiled and tested on the same example I used before and works :)

tomjaguarpaw commented 7 years ago

Thanks for testing, guys! It's good to get this fixed. It was a bit embarrassing :)

domenkozar commented 7 years ago

Thank you both! :)