Open tomjaguarpaw opened 6 years ago
Tbh I never give strictness much thought until something breaks. Other instances for Procompose and Pair in profunctor/bifunctor don't seem to need anything special either, so why do these?
Fair enough. Let's leave that until we see a problem.
These instance methods look too strict.
https://github.com/tomjaguarpaw/product-profunctors/blob/b8635f819df2a9362940b5126427e45aa97f3040/Data/Profunctor/Product.hs#L110
https://github.com/tomjaguarpaw/product-profunctors/blob/b8635f819df2a9362940b5126427e45aa97f3040/Data/Profunctor/Product.hs#L127
https://github.com/tomjaguarpaw/product-profunctors/blob/b8635f819df2a9362940b5126427e45aa97f3040/Data/Profunctor/Product.hs#L145
https://github.com/tomjaguarpaw/product-profunctors/blob/b8635f819df2a9362940b5126427e45aa97f3040/Data/Profunctor/Product.hs#L154
@sjoerdvisscher Any thoughts?