optics - Githubissues

tomjaguarpaw / tilapia

Improving all Haskell's programmer interfaces

65 stars 2 forks source link

Open tomjaguarpaw opened 3 years ago

tomjaguarpaw commented 3 years ago

matching not mentioned prominently [FIXED]

~Seems like it should appear under Elimination~

~PR open~
Easier way to do Prism s t a b -> b -> t

Currently the easiest way seems to be withPrism
Why does it have isn't but not is?! [FIXED]

~PR merged~

arybczak commented 3 years ago

Currently the easiest way seems to be withPrism

What about review or (#)?

tomjaguarpaw commented 3 years ago

They have types

review :: Is k A_Review => Optic' k is t b -> b -> t 
(#) :: Is k A_Review => Optic' k is t b -> b -> t

i.e. they don't work on type-changing Prisms.

tomjaguarpaw commented 2 years ago

Next action:

[ ] Determine whether there's actually a need to do Prism s t a b -> b -> t on type-changing prisms (I can't remember what I was using this for originally)
[ ] If there is a need, determine whether anything exists in the library already
[ ] If not, submit a PR