search

tomjn / Shard

A reprogrammable AI framework for the Spring Engine
https://shard.tomjn.com
17 stars 13 forks source link

remove all submodules #110

Closed abma closed 7 years ago

abma commented 8 years ago

why?

they create way more trouble than they solve + the submodules seems basicly unused.

tomjn commented 7 years ago

They are used, they contain overrides for BA and BAR. The files are never explicitly included because that's not how overrides in Shard work. This also means duplication of work for @eronoobos as this code appears in more than 1 project ( https://github.com/eronoobos/ShardSpringLua )

tomjn commented 7 years ago

@abma as an aside, could the build system simply not call the submodule init/update commands? A git clone of Shard by itself isn't enough to initialise and fill in the submodules

abma commented 7 years ago

not used = they are only used in Shard and they are not maintained + broken

tomjn commented 7 years ago

Have you opened issues with the respective repos? Merging the submodules won't fix any lua bugs

@eronoobos are you still maintaining or is a new maintainer necessary?