tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
248 stars 91 forks source link

feat: POC of adding subscription_name to metric labels #2279

Open jiping-s opened 1 year ago

jiping-s commented 1 year ago

This is a proof of concept for adding subscription_name (1:1 to subscription_id) for metrics. I don't have time to complete it for all the requirements, but if anyone is interested please take it over.

Applies to both of azure metrics and promitor's internal metrics.

How it works:

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: tomkerkhove
:x: jiping-s
You have signed the CLA already but the status is still pending? Let us recheck it.

tomkerkhove commented 1 year ago

Thank you! I'll review it asap

tomkerkhove commented 1 year ago

This is for https://github.com/tomkerkhove/promitor/issues/1665 I presume?