search

tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
249 stars 91 forks source link

Add Basic Authentication Support for OpenTelemetryCollector Configuration #2294

Open bunkrur opened 1 year ago

bunkrur commented 1 year ago

Proposal

Issue Description I'd like to be able to use authentication against an OpenTelemetry collector endpoint within the Promiter configuration. Currently, I am having to forward to proxy collector that is handling the authentication and then forwarding to yet another collector (observability for an organization of organizations). It would be amazing to be able to egress to a collector with authentication.

Proposed Solution Add the ability to specify header authentication

openTelemetryCollector:
  enabled: true
  collectorUri: "http://{{ .Values.runtime.metricSinks.openTelemetryCollector.dns }}:4317"
  headers:
    Authorization:. {{ Values.runtime.metricSinks.openTelemetryCollector.AuthorizationValue}}

Component

Resource Discovery, Scraper

Contact Details

No response

tomkerkhove commented 1 year ago

Interesting idea, are you willing to contribute this?

bunkrur commented 1 year ago

Going to say yes. Can we sync over a call about how you might want it implemented?

tomkerkhove commented 1 year ago

It depends what you want to discuss - I prefer to see what the current documentation lacks that avoids you from finding what you need so that I can improve it for other maintainers (don't get me wrong)