tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
248 stars 91 forks source link

Add Protocol option for AddOtlpExporter #2316

Open bunkrur opened 1 year ago

bunkrur commented 1 year ago

Proposal

I'd like to be able to specify the protocol for exporting via OTLP. I believe this can be simply accomplished by adding an option to the exporter with an option:

options.Protocol = (metricSinkConfiguration.OpenTelemetryCollector.CollectorProtocol.StartsWith("https")) ? OtlpExporterProtocol.HttpProtobuf : OtlpExporterProtocol.Grpc

Component

Scraper

Contact Details

b.unkrur@gmail.com

bunkrur commented 1 year ago

https://github.com/tomkerkhove/promitor/pull/2321