search

tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
249 stars 91 forks source link

feat: Provide capability to use multiple metric dimensions #2351

Closed amirschw closed 1 year ago

amirschw commented 1 year ago

Fixes #1820

Based on #2123 (thanks @aaronweissler and @Patrick-Eichhorn!)

github-actions[bot] commented 1 year ago

Thank you for your contribution! 🙏 We will review it as soon as possible.

amirschw commented 1 year ago

The scraper tests fail because of OTEL metrics and indeed I don't see any metrics in Show Prometheus metrics for OpenTelemetry agent. @tomkerkhove, since the integration tests all run successfully for me locally, would you mind rerunning the test to see if it's a transient issue?

tomkerkhove commented 1 year ago

/azp run Promitor CI - Scraper Agent

azure-pipelines[bot] commented 1 year ago

No commit pushedDate could be found for PR 2351 in repo tomkerkhove/promitor

amirschw commented 1 year ago

Looks like it was indeed a transient issue, since it's all green now 😄

tomkerkhove commented 1 year ago

Can you open a companion PR for the docs please?

amirschw commented 1 year ago

I was going to but noticed it's already supported according to the docs 😄 https://github.com/promitor/docs/pull/38

tomkerkhove commented 1 year ago

Woops, that already got merged